Are diamonds really rare, or is that a myth?
Yes, it's a myth. I know people at De Beers, and other large mining companies. They swear there are no Indiana Jones style warehouses full of diamonds. De Beers acknowledges this USED TO be a thing, but hasn't been for 30+ years.
Jewelry quality diamonds over 1ct are genuinely very rare. When people spout the "diamonds aren't rare" trope, they're using numbers that refer to ALL diamonds mined - including tiny ones, and very low quality stones suitable for industrial use (saw blades, drill bits, etc.) but not jewelry. Of course, those are much more common.